Just to clarify, im pretty sure that when he referred to it as immoral, he meant the idea of blowing your load soley for some quick cash, without really understanding what is involved. If we're going to liken it to adoption and surrogacy; in the process of adopting your child out, would you ask for some quick cash? And how would you determine how much your child is worth? An extra thousand if they happen to come out with blonde hair?
Actually, if you look back at the post I was responding to, he said "I personally would never bother with it as i find it immoral (imo) and
totally defeats the purpose of enjoying a family of your own." (emphasis added).
He thinks it's immoral to not raise your own family, not to get cash in exchange for his donation. In that sense, it is absolutely similar to adoption and surrogacy. In both cases, you are birthing or raising a child that you did not genetically create.
If his complaint was with the exchange of money for a body parts, that's a different story. Historically, all countries have made it illegal to sell any part of the body (including for sex), but those laws are slowly being replaced. Prostitution is permitted in several countries, the sale of blood is permitted almost everywhere in the U.S., and the sale of dead bodies and body parts is permitted as long as the use is medical in nature. Several years ago, Egypt was having serious problems with a black market for vital organs, and the lawmakers seriously started to consider legalizing the sale of those organs so that it could be standardized.
Most of the laws on the books prohibiting the sale of body parts come from christianity, judaism and islam. As society moves away from religious values, so too will the restrictions on the sale of body parts.